-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Revert "[ci] enabling python 3.10 for subset of ci tests" #58160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[ci] enabling python 3.10 for subset of ci tests" #58160
Conversation
This reverts commit 2005cb2.
| PYTHON_VERSION: "{{matrix.python}}" | ||
| EXTRA_DEPENDENCY: "{{matrix.app}}" | ||
| PYTHON_VERSION: "3.9" | ||
| EXTRA_DEPENDENCY: "{{matrix}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Python Version Mismatch in Build Names
The label template "wanda: minbuild-{{matrix}}-py39" will generate build names like minbuild-default-py39 and minbuild-serve-py39 (without a dot between 3 and 9), but the build-name references in the commands at lines 151 and 164 use minbuild-default-py3.9 and minbuild-serve-py3.9 (with a dot). This naming mismatch will cause test steps to fail when they cannot find the referenced build artifacts. The label template should use py{{matrix}}.9 instead of py39 to generate the correct build names, or the build-name references should be changed to match the new template format (without the dot).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change that enabled Python 3.10 for a subset of CI tests. The changes correctly remove Python 3.10 from various test matrices and CI configurations across multiple .buildkite YAML files. Hardcoded versions and dependencies are consistently reverted from 3.10 to 3.9. The modifications appear correct and align with the goal of the revert.
…t#58160) Reverts ray-project#58036 Signed-off-by: xgui <[email protected]>
…t#58160) Reverts ray-project#58036 Signed-off-by: Aydin Abiar <[email protected]>
…t#58160) Reverts ray-project#58036 Signed-off-by: Future-Outlier <[email protected]>
Reverts #58036