[core][event] feature flag for enabling ray export event #57999
Merged
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds a feature flag to control the start of Ray event exporting. My review points out a potential for unnecessary resource usage when event exporting is disabled and suggests a follow-up improvement to address it.
can-anyscale
force-pushed
the
can-1event06
branch
2 times, most recently
from
df575c5 to
17f7d56
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
can-anyscale
force-pushed
the
can-1event06
branch
from
17f7d56 to
ac3a2a7
Compare
ray-gardener
bot
added
core
edoakes
reviewed
Oct 22, 2025
| } | ||
| } | ||
|
|
||
| bool RayEventRecorder::isEnabled() { return RayConfig::instance().enable_ray_event(); } |
Collaborator
There was a problem hiding this comment.
looks like the method is unnecessary -- it's only used internally and it's a one liner, so I'd just inline the config check
edoakes
approved these changes
Oct 22, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
lgtm aside from other nit. also: does it need to be cherry picked?
Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
force-pushed
the
can-1event06
branch
from
ac3a2a7 to
8a2f851
Compare
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 27, 2025
…#57999) We have a feature flag to control the rolling out of ray export event, but the feature flag is missing the controlling of `StartExportingEvents`. This PR fixes the issue. Test: - CI Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: xgui <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…#57999) We have a feature flag to control the rolling out of ray export event, but the feature flag is missing the controlling of `StartExportingEvents`. This PR fixes the issue. Test: - CI Signed-off-by: Cuong Nguyen <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…#57999) We have a feature flag to control the rolling out of ray export event, but the feature flag is missing the controlling of `StartExportingEvents`. This PR fixes the issue. Test: - CI Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a feature flag to control the rolling out of ray export event, but the feature flag is missing the controlling of
StartExportingEvents. This PR fixes the issue.Test: