[tune] update release tests to import from tune #57956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release tests to import from ray.tune instead of ray.train. The changes involve modifying import statements and updating the report function calls in two files: tune_scale_up_down.py and test_tune_worker_fault_tolerance.py. The goal is to align the tests with the changes described in the linked issue.
| import ray | ||
|
|
||
| from ray import train, tune | ||
| from ray import tune |
Contributor
There was a problem hiding this comment.
This change removes train from the import statement. Ensure that train is not used anywhere else in this file, as this could lead to errors.
| import ray | ||
| from ray import train | ||
| from ray.train import Checkpoint, RunConfig, FailureConfig, CheckpointConfig | ||
| from ray.tune import Checkpoint, RunConfig, FailureConfig, CheckpointConfig |
Contributor
There was a problem hiding this comment.
This change updates the import statement to import Checkpoint, RunConfig, FailureConfig, and CheckpointConfig from ray.tune instead of ray.train. Verify that this change aligns with the intended behavior and that these classes are correctly implemented and available in the current context.
Signed-off-by: Matthew Deng <[email protected]>
JasonLi1909
reviewed
Oct 21, 2025
JasonLi1909
approved these changes
Oct 21, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Description Fix release tests that are still importing from `ray.train` to import from `ray.tune`, as described in #49454. ## Additional information Test Runs: | Test Name | Before | After| | --- | --- | ---| | `cluster_tune_scale_up_down.aws` | https://buildkite.com/ray-project/release/builds/64733#019a0546-dbe2-47b1-ba85-983d48098352 | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc62-4177-a24a-b23806cd0d51 | | `cluster_tune_scale_up_down.kuberay` | https://buildkite.com/ray-project/release/builds/64733#019a0549-25dd-4dd3-ba84-df9d3ce5a72a | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc63-49b3-8efc-ff3bd5fb8d28 | | `tune_worker_fault_tolerance` | https://buildkite.com/ray-project/release/builds/64734#019a058c-2f15-401c-88d9-894002152fff | https://buildkite.com/ray-project/release/builds/64845/steps/canvas?sid=019a08aa-6c85-43d4-83e0-bf56d49ab474 | --------- Signed-off-by: Matthew Deng <[email protected]> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description Fix release tests that are still importing from `ray.train` to import from `ray.tune`, as described in ray-project#49454. ## Additional information Test Runs: | Test Name | Before | After| | --- | --- | ---| | `cluster_tune_scale_up_down.aws` | https://buildkite.com/ray-project/release/builds/64733#019a0546-dbe2-47b1-ba85-983d48098352 | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc62-4177-a24a-b23806cd0d51 | | `cluster_tune_scale_up_down.kuberay` | https://buildkite.com/ray-project/release/builds/64733#019a0549-25dd-4dd3-ba84-df9d3ce5a72a | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc63-49b3-8efc-ff3bd5fb8d28 | | `tune_worker_fault_tolerance` | https://buildkite.com/ray-project/release/builds/64734#019a058c-2f15-401c-88d9-894002152fff | https://buildkite.com/ray-project/release/builds/64845/steps/canvas?sid=019a08aa-6c85-43d4-83e0-bf56d49ab474 | --------- Signed-off-by: Matthew Deng <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description Fix release tests that are still importing from `ray.train` to import from `ray.tune`, as described in ray-project#49454. ## Additional information Test Runs: | Test Name | Before | After| | --- | --- | ---| | `cluster_tune_scale_up_down.aws` | https://buildkite.com/ray-project/release/builds/64733#019a0546-dbe2-47b1-ba85-983d48098352 | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc62-4177-a24a-b23806cd0d51 | | `cluster_tune_scale_up_down.kuberay` | https://buildkite.com/ray-project/release/builds/64733#019a0549-25dd-4dd3-ba84-df9d3ce5a72a | https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc63-49b3-8efc-ff3bd5fb8d28 | | `tune_worker_fault_tolerance` | https://buildkite.com/ray-project/release/builds/64734#019a058c-2f15-401c-88d9-894002152fff | https://buildkite.com/ray-project/release/builds/64845/steps/canvas?sid=019a08aa-6c85-43d4-83e0-bf56d49ab474 | --------- Signed-off-by: Matthew Deng <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix release tests that are still importing from
ray.trainto import fromray.tune, as described in #49454.Additional information
Test Runs:
cluster_tune_scale_up_down.awscluster_tune_scale_up_down.kuberaytune_worker_fault_tolerance