Skip to content

Conversation

@khluu
Copy link
Contributor

@khluu khluu commented Oct 20, 2025

It used to be in 3 different groups, now unionized in 1.

p
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from aslonnie October 20, 2025 19:17
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly unifies the hello_world related tests under a single hello_world group in release/release_tests.yaml. This change improves the organization of tests in the Buildkite UI as intended. The implementation is clean and correct. I have reviewed the changes and found no issues.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Oct 20, 2025
@aslonnie aslonnie enabled auto-merge (squash) October 20, 2025 19:38
@aslonnie aslonnie merged commit 670151e into master Oct 20, 2025
7 checks passed
@aslonnie aslonnie deleted the khluu/group_hello_world branch October 20, 2025 19:52
kamil-kaczmarek pushed a commit that referenced this pull request Oct 20, 2025
It used to be in 3 different groups, now unionized in 1.

Signed-off-by: kevin <[email protected]>
Signed-off-by: Kamil Kaczmarek <[email protected]>
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 22, 2025
It used to be in 3 different groups, now unionized in 1.

Signed-off-by: kevin <[email protected]>
Signed-off-by: xgui <[email protected]>
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
It used to be in 3 different groups, now unionized in 1.

Signed-off-by: kevin <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
It used to be in 3 different groups, now unionized in 1.

Signed-off-by: kevin <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
It used to be in 3 different groups, now unionized in 1.

Signed-off-by: kevin <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants