Skip to content

Conversation

@daiping8
Copy link
Contributor

Description

Add missing imports to autoscaling policy example

Related issues

Link related issues: #57876 (comment)

Change-Id: I1332b0e68caea3f3f27b3da70ceffb3f581d62a9
Signed-off-by: daiping8 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds missing imports to the autoscaling policy examples in the documentation, making the code snippets self-contained and runnable. My review includes a minor suggestion to improve the import order in one of the snippets to adhere to PEP 8 standards for better code organization and readability.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Ping Dai <[email protected]>
@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Oct 20, 2025
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue community-contribution Contributed by the community labels Oct 20, 2025
@abrarsheikh abrarsheikh merged commit 58a4fcd into ray-project:master Oct 27, 2025
7 checks passed
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…roject#57896)

## Description
Add missing imports to autoscaling policy example

## Related issues
Link related issues:
ray-project#57876 (comment)

---------

Signed-off-by: daiping8 <[email protected]>
Signed-off-by: Ping Dai <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
…roject#57896)

## Description
Add missing imports to autoscaling policy example

## Related issues
Link related issues:
ray-project#57876 (comment)

---------

Signed-off-by: daiping8 <[email protected]>
Signed-off-by: Ping Dai <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants