[codeowners] Reorder CODEOWNERS for resolution order + organization
#57891
Conversation
Signed-off-by: Seiji Eicher <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly reorganizes the CODEOWNERS file to ensure the LLM team is designated as the owner for files under python/ray/serve/llm/, overriding the more general rule for python/ray/serve/. The consolidation of all LLM-related rules into a single block also improves the file's organization and readability. I have one suggestion to further simplify the configuration by using a glob pattern for related dashboard files.
| /python/ray/dashboard/modules/metrics/dashboards/serve_llm_dashboard_panels.py @ray-project/ray-llm | ||
| /python/ray/dashboard/modules/metrics/dashboards/serve_llm_grafana_dashboard_base.json @ray-project/ray-llm |
There was a problem hiding this comment.
For better maintainability, you can combine these two lines into a single line using a glob pattern. This will simplify the file and automatically include any new serve_llm_* files in this directory in the future.
/python/ray/dashboard/modules/metrics/dashboards/serve_llm_* @ray-project/ray-llm
ray-gardener
bot
added
serve
|
@eicherseiji could you rebase? I am not sure if micro check failure is valid. |
…#57891) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: Kamil Kaczmarek <[email protected]>
…ray-project#57891) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: xgui <[email protected]>
…#57891) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: elliot-barn <[email protected]>
…ray-project#57891) Signed-off-by: Seiji Eicher <[email protected]>
…ray-project#57891) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
…ray-project#57891) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
3 participants
Description
python/ray/serve/llm/openai_api_models.py. So this PR adds LLM as a code owner forserve/llm/serve/anddata/. So Serve team ownsserve/directories, but LLM team should ownserve/llm/CODEOWNERSresolves top to bottom, LLM rules should be at the bottom, since they are more tightly scoped.