[core] Make DrainRaylet + ShutdownRaylet Fault Tolerant #57861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshlee <[email protected]>
dayshah
approved these changes
Oct 19, 2025
| return not node["Alive"] | ||
| return True | ||
|
|
||
| wait_for_condition(node_is_dead, timeout=30) |
Contributor
There was a problem hiding this comment.
how long does this test take to finish?
Collaborator
There was a problem hiding this comment.
timeout=30 is no bueno! maybe need to tune some timeout env var?
Contributor
Author
There was a problem hiding this comment.
Total test takes around 2.5 - 3 seconds on avg to complete? The wait_for_condition itself though is only a millisecond or two, looks like 30 sec even as a failsafe was a bit excessive 😅. I'll reduce it down to 1 sec.
Collaborator
|
@Sparks0219 Jiajun's PR is merged, can rebase now |
Signed-off-by: joshlee <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: joshlee <[email protected]>
kamil-kaczmarek
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: joshlee <[email protected]> Signed-off-by: Kamil Kaczmarek <[email protected]>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…57861) Signed-off-by: joshlee <[email protected]> Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: joshlee <[email protected]> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…57861) Signed-off-by: joshlee <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…57861) Signed-off-by: joshlee <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making DrainRaylet and ShutdownRaylet Fault Tolerant and Idempotent. Added cpp tests for DrainRaylet to verify idempotency and added a python integration test. Not adding cpp/python tests for ShutdownRaylet as it's evidently idempotent and not much point in cpp testing since the callbacks are set in main.cc so would just be re-implementing this logic in node_manager_test.cc.