[core] Kill raylet file and just keep node manager file #57817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <[email protected]>
Signed-off-by: dayshah <[email protected]>
Signed-off-by: dayshah <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: dayshah <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
edoakes
approved these changes
Oct 20, 2025
| acceptor_.async_accept( | ||
| socket_, | ||
| boost::bind(&NodeManager::HandleAccept, this, boost::asio::placeholders::error)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Hm... this does look right -- how is it working now?! Maybe the socket move constructor is fake news and just copies?
Collaborator
|
Thanks @dayshah |
Signed-off-by: dayshah <[email protected]>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…57817) Signed-off-by: dayshah <[email protected]> Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: dayshah <[email protected]> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…57817) Signed-off-by: dayshah <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…57817) Signed-off-by: dayshah <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The raylet file is unnecessary, there should just be one main raylet file, so killing the raylet file and just keeping node manager. It only existed for legacy reasons. In the future "NodeManager" can be renamed to raylet and NodeManagerService can be renamed to RayletService, etc.