[lint][ci] removing format script #57799
Conversation
Signed-off-by: elliot-barn <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to remove the format.sh script and its references. The changes correctly remove references to the script from the CI configuration, CODEOWNERS, and pre-commit setup. However, the script file ci/lint/format.sh itself has not been deleted. To complete the removal as intended, the file should also be deleted from the repository.
| #/ci/ @ray-project/ray-core @ray-project/ray-ci | ||
|
|
||
| # CI | ||
| /ci/lint/format.sh @ray-project/ray-ci |
There was a problem hiding this comment.
While removing the code ownership for ci/lint/format.sh is correct, the script file itself has not been deleted in this pull request. To fully remove the script as described in the pull request's title and description, please also delete the ci/lint/format.sh file.
Signed-off-by: elliot-barn <[email protected]>
|
resolve conflicts on lint.sh ? |
aslonnie
left a comment
aslonnie
left a comment
There was a problem hiding this comment.
(please ask me to review again when the conflict is resolved)
Signed-off-by: elliot-barn <[email protected]>
removing format script and all references --------- Signed-off-by: elliot-barn <[email protected]> Signed-off-by: xgui <[email protected]>
|
We should also remove the symlink https://github.com/ray-project/ray/blob/444646e0592f40e8635e639f5f9d5c8cc324070c/scripts/format.sh |
removing format script and all references --------- Signed-off-by: elliot-barn <[email protected]>
removing format script and all references --------- Signed-off-by: elliot-barn <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
removing format script and all references