-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[docs] Expose dashboard url when deploying on Yarn using Skein #57793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import skein | ||
| import sys | ||
| from urllib.parse import urlparse | ||
|
|
||
| if __name__ == "__main__": | ||
| if len(sys.argv) < 2: | ||
| print("Usage: python dashboard.py <dashboard-address>") | ||
| sys.exit(1) | ||
|
Comment on lines
+6
to
+8
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As there is only one required argument, I'd keep it simple as is. |
||
| address = sys.argv[1] | ||
| # Check if the address is a valid URL | ||
| result = urlparse(address) | ||
| if not all([result.scheme, result.netloc]): | ||
| print("Error: Invalid dashboard address. Please provide a valid URL.") | ||
| sys.exit(1) | ||
|
|
||
| print("Registering dashboard " + address + " on skein.") | ||
| app = skein.ApplicationClient.from_current() | ||
| app.ui.add_page("ray-dashboard", address, "Ray Dashboard") | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import skein | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems to be the same file from
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I noticed there are same files under |
||
| import sys | ||
| from urllib.parse import urlparse | ||
|
|
||
| if __name__ == "__main__": | ||
| if len(sys.argv) < 2: | ||
| print("Usage: python dashboard.py <dashboard-address>") | ||
| sys.exit(1) | ||
| address = sys.argv[1] | ||
| # Check if the address is a valid URL | ||
| result = urlparse(address) | ||
| if not all([result.scheme, result.netloc]): | ||
| print("Error: Invalid dashboard address. Please provide a valid URL.") | ||
| sys.exit(1) | ||
|
|
||
| print("Registering dashboard " + address + " on skein.") | ||
| app = skein.ApplicationClient.from_current() | ||
| app.ui.add_page("ray-dashboard", address, "Ray Dashboard") | ||
Uh oh!
There was an error while loading. Please reload this page.