Skip to content

[Data] - Add _source_paths to filedatasources #57574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykudinkin merged 2 commits into from
Oct 10, 2025
Merged

[Data] - Add _source_paths to filedatasources #57574

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041a40f
[Data] - Add _unresolved_paths to filedatasources
goutamvenkat-anyscale Oct 8, 2025
59402e1
Use source_paths instead
goutamvenkat-anyscale Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/ray/data/_internal/datasource/parquet_datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ def __init__(
self._local_scheduling = NodeAffinitySchedulingStrategy(
ray.get_runtime_context().get_node_id(), soft=False
)

# Need this property for lineage tracking
self._unresolved_paths = paths
Comment thread
goutamvenkat-anyscale marked this conversation as resolved.
Outdated

@alexeykudinkin alexeykudinkin Oct 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._unresolved_paths = paths
self._source_paths = paths

@alexeykudinkin alexeykudinkin Oct 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: To make its intention clear (that these are original/source paths)

@sanketrai sanketrai Oct 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep it _unresolved_paths to avoid breaking the OpenLineage plugin code? We can rather add a description here to make the intention clear.

@alexeykudinkin alexeykudinkin Oct 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanketrai i'm not following? Why can't you use _source_path

@sanketrai sanketrai Oct 10, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use, it's just that we have been using _unresolved_paths with previous versions of Ray. We'll need to add a version check in our code to toggle between _unresolved_paths and _source_paths. But that's manageable. We can go ahead with _source_paths.

@alexeykudinkin alexeykudinkin Oct 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i see what you're saying. That makes sense.

@goutamvenkat-anyscale i'm fine in that case with _unresolved_paths

paths, self._filesystem = _resolve_paths_and_filesystem(paths, filesystem)
filesystem = RetryingPyFileSystem.wrap(
self._filesystem,
Expand Down
2 changes: 2 additions & 0 deletions python/ray/data/datasource/file_based_datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ def __init__(
self._partitioning = partitioning
self._ignore_missing_paths = ignore_missing_paths
self._include_paths = include_paths
# Need this property for lineage tracking
self._unresolved_paths = paths
Comment thread
goutamvenkat-anyscale marked this conversation as resolved.
Outdated
paths, self._filesystem = _resolve_paths_and_filesystem(paths, filesystem)
self._filesystem = RetryingPyFileSystem.wrap(
self._filesystem, retryable_errors=self._data_context.retried_io_errors
Expand Down
1 change: 1 addition & 0 deletions python/ray/data/tests/test_streaming_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ def udf(row):
assert isinstance(logical_ops[0], Read)
datasource = logical_ops[0]._datasource
assert isinstance(datasource, ParquetDatasource)
assert datasource._unresolved_paths == input_path

assert isinstance(logical_ops[1], MapRows)
assert logical_ops[1]._fn == udf
Expand Down