-
Notifications
You must be signed in to change notification settings - Fork 7k
[data] Refractor progress bar clearer metrics #57094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexeykudinkin
merged 13 commits into
ray-project:master
from
iamjustinhsu:jhsu/use-outputs-generated-for-pg
Oct 24, 2025
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e8a6d08
[data] Refine estimate for total_num_rows in progress bars
iamjustinhsu a909536
keep finished + ongoing tasks
iamjustinhsu 9690830
Merge branch 'master' of https://github.com/ray-project/ray into jhsu…
iamjustinhsu 648e5b5
move estimation in output generation
iamjustinhsu e3f5554
remove print
iamjustinhsu aa2a6b8
more accurate
iamjustinhsu f63c0c1
case for num_tasks_finished == 0
iamjustinhsu 444cebb
remove code
iamjustinhsu 8a84a06
comments
iamjustinhsu e8278df
Merge branch 'master' into jhsu/use-outputs-generated-for-pg
iamjustinhsu f3d854c
fix
iamjustinhsu f8ba30a
lint
iamjustinhsu 37bd144
check for None or 0
iamjustinhsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,6 @@ def __init__( | |
| data_context: DataContext, | ||
| input_data: Optional[List[RefBundle]] = None, | ||
| input_data_factory: Optional[Callable[[int], List[RefBundle]]] = None, | ||
| num_output_blocks: Optional[int] = None, | ||
| ): | ||
| """Create an InputDataBuffer. | ||
|
|
||
|
|
@@ -30,8 +29,6 @@ def __init__( | |
| object to use injestion. | ||
| input_data: The list of bundles to output from this operator. | ||
| input_data_factory: The factory to get input data, if input_data is None. | ||
| num_output_blocks: The number of output blocks. If not specified, progress | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not being used anywhere |
||
| bars total will be set based on num output bundles instead. | ||
| """ | ||
| super().__init__("Input", [], data_context) | ||
| if input_data is not None: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.