Skip to content

Fix/ray serve test state api usage #56948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abrarsheikh merged 20 commits into from
Oct 21, 2025
Merged

Fix/ray serve test state api usage #56948

abrarsheikh merged 20 commits into from
Oct 21, 2025

Conversation

@jcarlson212
Copy link
Contributor

@jcarlson212 jcarlson212 commented Sep 26, 2025

Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

Related issue number

Fixes #53478

Checks

  • [y] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [y] I've run scripts/format.sh to lint the changes in this PR.
  • [y] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • [y] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/.
  • Testing Strategy
    • [y] Unit tests
    • Release tests
    • This PR is not tested :(

jcarlson212 and others added 19 commits September 23, 2025 22:23
@jcarlson212
Move state.actors() to _common
a859608 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Use Public State API for Fetching Actors
940c38b 
Instead of fetching actors from the internal state API / migrating it to
the common module, simply reference the public state API that relies on the dashboard
server.

Signed-off-by: Jason <[email protected]>
@jcarlson212
Resolve Buildkite and Cursor Issues
635e26c 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Fix Tests
d028fb4 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Ensure ray.util.state Module is Available in Test Envs
25b9c19 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Add detail=True for NodeId and NumRestarts
9b8867a 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Override Ruff for Module Import
30ac5de 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Resolve Remaining Import State Module Errors on Remote Workers
3829392 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Improve Import Hygiene and Cut RuntimeContext DepOn Dashboard
67427df 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Fix Runtime Context State Submodule Loading Bug
f9f5aac 
Fixes the runtime context state submodule loading bug by importing
the state API module as STATE at the top of the file. Uses similar safety precaution in
the dataset.py file since these were the only two public API spots recently changed (not isolated to
just tests).

Signed-off-by: Jason <[email protected]>
@jcarlson212
Remove State Import Aliases
5b6e94b 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Fix Shutdown Only Dashboard Initialization Bug
1d7ba7e 
The dashboard wasn't being initialized before unit tests for shutdown_only fixtures
since the params get ignored, causing some unit tests to fail.

Signed-off-by: Jason <[email protected]>
@jcarlson212
Add Back _private Actors Timestamps Unit Test
63445c9 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Add Ray Dashboard Init To Failing Actor Tests
2fa9774 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Add Dashboard to Fix More Tests
d4211fa 
Signed-off-by: Jason <[email protected]>
@jcarlson212
Remove Redundant Imports, Dataset.py Ref Revert, Improve Hygeine
8ed77e9 
Signed-off-by: Jason <[email protected]>
@edoakes
Merge branch 'master' into master
e8a10c8
@jcarlson212
Merge branch 'ray-project:master' into master
5dc24d5
@jcarlson212
Fix Test Usage of Old ActorState to Use New Instead
74fa3ab 
Signed-off-by: Jason <[email protected]>
@jcarlson212 jcarlson212 requested a review from a team as a code owner September 26, 2025 02:45
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the test_actor_summary unit test within python/ray/serve/tests/test_metrics.py. The test was using dictionary-style access (actor['class_name']) on objects returned by list_actors, which now returns a list of ActorState dataclass objects. The fix correctly changes this to attribute-style access (actor.class_name). This change is correct and aligns the test with the current ray.util.state API, resolving the issue.

@jcarlson212 jcarlson212 mentioned this pull request Sep 26, 2025
Merged
8 tasks
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue community-contribution Contributed by the community labels Sep 26, 2025
@jcarlson212
Copy link
Contributor Author

jcarlson212 commented Oct 5, 2025

@edoakes Who's a good reviewer to look at this? It's an extremely small change that fell out of the PR you reviewed for migrating the state#actors method calls to the public API (list_actors, get_actor).

@edoakes
Copy link
Collaborator

edoakes commented Oct 5, 2025

@zcin @abrarsheikh PTAL

@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Oct 5, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 20, 2025
@abrarsheikh
Copy link
Contributor

abrarsheikh commented Oct 20, 2025

@jcarlson212 changes look good, mind merging master into your branch, premerge is failing

@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Oct 20, 2025
@abrarsheikh abrarsheikh merged commit 24c747c into ray-project:master Oct 21, 2025
6 checks passed
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 22, 2025
@jcarlson212 @edoakes @xinyuangui2
Fix/ray serve test state api usage (ray-project#56948)
0fc93af 
## Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

## Related issue number

Fixes ray-project#53478

## Checks

- [y] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [y] I've run `scripts/format.sh` to lint the changes in this PR.
- [y] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [y] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at
https://flakey-tests.ray.io/.
- Testing Strategy
   - [y] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jason <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Signed-off-by: xgui <[email protected]>
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
@jcarlson212 @edoakes @elliot-barn
Fix/ray serve test state api usage (#56948)
ef4bf8b 
## Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

## Related issue number

Fixes #53478 

## Checks

- [y] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [y] I've run `scripts/format.sh` to lint the changes in this PR.
- [y] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [y] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at
https://flakey-tests.ray.io/.
- Testing Strategy
   - [y] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jason <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@jcarlson212 @edoakes @landscapepainter
Fix/ray serve test state api usage (ray-project#56948)
0512b43 
## Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

## Related issue number

Fixes ray-project#53478 

## Checks

- [y] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [y] I've run `scripts/format.sh` to lint the changes in this PR.
- [y] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [y] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at
https://flakey-tests.ray.io/.
- Testing Strategy
   - [y] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jason <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
@jcarlson212 @edoakes
Fix/ray serve test state api usage (ray-project#56948)
d2ec211 
## Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

## Related issue number

Fixes ray-project#53478

## Checks

- [y] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [y] I've run `scripts/format.sh` to lint the changes in this PR.
- [y] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [y] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at
https://flakey-tests.ray.io/.
- Testing Strategy
   - [y] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jason <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
@jcarlson212 @edoakes @Future-Outlier
Fix/ray serve test state api usage (ray-project#56948)
18f4053 
## Why are these changes needed?

Fixes a unit test that was broken but not running in CI.

## Related issue number

Fixes ray-project#53478

## Checks

- [y] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [y] I've run `scripts/format.sh` to lint the changes in this PR.
- [y] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [y] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at
https://flakey-tests.ray.io/.
- Testing Strategy
   - [y] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Jason <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrarsheikh abrarsheikh abrarsheikh approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abrarsheikh abrarsheikh

@zcin zcin

Labels

community-contribution Contributed by the community go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[core|serve] Migrate shared utilities from ray._private to ray._common

4 participants

@jcarlson212 @edoakes @abrarsheikh @zcin