[core] Fixing windows build with cgroups. Broken in cgroups 10/n. #56626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: irabbani <[email protected]>
israbbani
added
go
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
…/ray into irabbani/windows-build-fix-1
Signed-off-by: irabbani <[email protected]>
jjyao
approved these changes
Sep 17, 2025
Comment on lines
+82
to
+88
| # Private targets | ||
| # | ||
| # TODO(#54703): This target builds the noop implementations. | ||
| # There's a corressponding test that runs on Linux and Non-Linux | ||
| # CI so breakages are caught in premerge before these targets are | ||
| # cleaned up at the end of the resource isolation milestone 1 | ||
| # project. |
Collaborator
There was a problem hiding this comment.
I feel we don't really need this given we are very close to remove the noop thing and I'm sure you won't miss it anymore.
Contributor
Author
There was a problem hiding this comment.
I plan on deleting this in a few more PRs. I added it so I don't accidentally break CI again with 11/n and 12/n.
Collaborator
|
Windows compilation errors. |
Contributor
Author
Unrelated. @Sparks0219 is looking into those. They're from the FakeRayClient. The python failure on windows is from |
Collaborator
|
trusting that compilation errors are unrelated |
zma2
pushed a commit
to zma2/ray
that referenced
this pull request
Sep 23, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Zhiqiang Ma <[email protected]>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: zac <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 24, 2025
…6626) Broken in #56446. This should stop being possible once there's a single cgroups target exported (as highlighted in #54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: elliot-barn <[email protected]>
marcostephan
pushed a commit
to marcostephan/ray
that referenced
this pull request
Sep 24, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Marco Stephan <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Sep 27, 2025
…6626) Broken in #56446. This should stop being possible once there's a single cgroups target exported (as highlighted in #54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: elliot-barn <[email protected]>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
…6626) Broken in #56446. This should stop being possible once there's a single cgroups target exported (as highlighted in #54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…y-project#56626) Broken in ray-project#56446. This should stop being possible once there's a single cgroups target exported (as highlighted in ray-project#54703). I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken in #56446.
This should stop being possible once there's a single cgroups target exported (as highlighted in #54703).
I've fixed the broken build and I've added a temporary test target that builds the noop implementations as part of Linux CI so it gets caught in premerge.