[Core][Autoscaler] Add labels to KubeRay autoscaling config
#56532
+76
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
Contributor
Author
|
cc: @MengjinYan |
ryanaoleary
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for labels in the KubeRay autoscaler configuration by introducing a new labels field. This field is parsed from the rayStartParams of a worker group spec in the Ray CR. The implementation includes a new function for parsing these labels with error handling, and the changes are well-supported by new unit tests. My feedback focuses on making the exception handling more specific to improve code robustness.
ryanaoleary
changed the title
labels to KubeRay autoscaling config
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ryan O'Leary <[email protected]>
ray-gardener
bot
added
docs
Signed-off-by: Ryan O'Leary <[email protected]>
MengjinYan
reviewed
Sep 15, 2025
Contributor
MengjinYan
left a comment
MengjinYan
left a comment
There was a problem hiding this comment.
Nice catch! All are nit comments.
Signed-off-by: Ryan O'Leary <[email protected]>
MengjinYan
approved these changes
Sep 16, 2025
Signed-off-by: Ryan O'Leary <[email protected]>
Contributor
|
The java test failure should be unrelated. cc: @jjyao |
35 tasks
jmajety-dev
pushed a commit
to jmajety-dev/ray
that referenced
this pull request
Sep 16, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]> Signed-off-by: zac <[email protected]>
marcostephan
pushed a commit
to marcostephan/ray
that referenced
this pull request
Sep 24, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]> Signed-off-by: Marco Stephan <[email protected]>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…oject#56532) Signed-off-by: Ryan O'Leary <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Mengjin Yan <[email protected]> Co-authored-by: Jiajun Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a new
labelsfield to the autoscaling config for the KubeRay autoscaler. This PR adds logic to detect labels from the worker group spec of a Ray CR. Ray node labels are specified per worker-group in KubeRay by passing them to therayStartParamsas follows:This change is required for the Ray autoscaler to scale available node types using labels.
Related issue number
#51564
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.