-
Notifications
You must be signed in to change notification settings - Fork 7k
[Core] Deflake test_put_out_of_disk #56442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
62bccfc
up
jjyao 6da3384
Merge branch 'master' of github.com:ray-project/ray into jjyao/bisecttt
jjyao 83dad27
debug
jjyao a36edd0
debug
jjyao a9564d3
up
jjyao 6520d39
up
jjyao 89ffd57
up
jjyao 9f6fec3
up
jjyao 4918b62
up
jjyao 97005dd
up
jjyao 63e4c7e
up
jjyao a49af03
pu
jjyao 29c8456
up
jjyao bd855c5
up
jjyao 54bf744
up
jjyao 90f3dd5
up
jjyao 3c8bbdc
revert
jjyao 4b830d7
Merge branch 'master' of github.com:ray-project/ray into jjyao/bisecttt
jjyao 113d0f2
Merge branch 'master' of github.com:ray-project/ray into jjyao/bisecttt
jjyao dad6e54
up
jjyao b37eb8a
up
jjyao 4ed73dd
Deflake test_put_out_of_disk
jjyao 2a709b3
up
jjyao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the CI machine, the
get_current_usage()is not immediately updated after the tmp_file is deleted for some reason so I'm usingwait_for_condition()here to give it some time to update it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave a comment on get_current_usage that it could be potentially flaky due to file size not being immediately updated + should be used with wait_for_condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool thanks