-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[LLM] Bump to nixl==0.4.1 #55671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLM] Bump to nixl==0.4.1 #55671
Changes from 7 commits
27394e3
7e248db
aaad1d1
3683856
f9851b9
b2a3165
55b27a5
b5109d5
6cb4032
3f43983
64fc537
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -13,8 +13,8 @@ mkdir -p /tmp/ray-deps | |||||||||||||
|
|
||||||||||||||
| # Remove the GPU constraints | ||||||||||||||
| cp python/requirements_compiled.txt /tmp/ray-deps/requirements_compiled.txt | ||||||||||||||
| sed -i '/^--extra-index-url /d' /tmp/ray-deps/requirements_compiled.txt | ||||||||||||||
| sed -i '/^--find-links /d' /tmp/ray-deps/requirements_compiled.txt | ||||||||||||||
| sed -e '/^--extra-index-url /d' -e '/^--find-links /d' /tmp/ray-deps/requirements_compiled.txt > /tmp/ray-deps/requirements_compiled.txt.tmp | ||||||||||||||
| mv /tmp/ray-deps/requirements_compiled.txt.tmp /tmp/ray-deps/requirements_compiled.txt | ||||||||||||||
|
Comment on lines
15
to
+17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These three lines can be simplified into a single
Suggested change
Comment on lines
+16
to
+17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this change? |
||||||||||||||
|
|
||||||||||||||
| bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/rayllm.depsets.yaml | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ build_arg_sets: | |
| - --extra-index-url https://download.pytorch.org/whl/${CUDA_CODE} | ||
| append_flags: | ||
| - --python-version=3.11 | ||
| - --python-platform=x86_64-manylinux_2_28 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we use |
||
| build_arg_sets: | ||
| - cpu | ||
| - cu121 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
//conditions:defaultto fall back to thelinux_x86_64binary might cause confusing runtime errors on unsupported platforms (e.g.,linux_aarch64). When an unsupported platform is used, it will attempt to use the x86_64 binary and fail. It would be more robust to have the build fail explicitly during the analysis phase for unsupported platforms. Consider removing the default case, which will cause Bazel to error out if no condition matches, providing a clearer error to the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we can scrap the default and error out if an supported platform is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do check and throw an error for unsupported platforms in raydepsets but I don't see the point in using a default here?