-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[Misc] Make compile_llm_requirements.sh runnable on macos
#55664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
27394e3
7e248db
aaad1d1
b2a3165
b5109d5
6cb4032
d1f744b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ build_arg_sets: | |
| - --extra-index-url https://download.pytorch.org/whl/${CUDA_CODE} | ||
| append_flags: | ||
| - --python-version=3.11 | ||
| - --python-platform=x86_64-manylinux_2_28 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should be or does generic the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did hit error
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have you tried
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
and for my own reference astral-sh/uv#14300 uv is aliasing |
||
| build_arg_sets: | ||
| - cpu | ||
| - cu121 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just because mac's
seddoes not have a-i?maybe convert this into a python script (or
py_binary) instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH python is less readable than
sed, I used temporary file due to #55664 (comment)