[Build][Bugfix] Fix protobuf version #54910

MengqingCao · 2025-07-25T01:34:02Z

Why are these changes needed?

This pr fixes the AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict using protobuf

Related issue number

Closes #54849

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

gemini-code-assist

Summary of Changes

Hello @MengqingCao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build-related bug by updating the protobuf dependency version. The change aims to resolve a specific AttributeError encountered when packaging messages to dictionaries, ensuring compatibility and proper functioning of protobuf-related operations.

Highlights

Dependency Update: The protobuf library dependency has been updated in python/requirements.txt to >3.20.0. This change specifically removes the previous version constraint !=3.19.5,>=3.15.3.
Bug Fix: This dependency update is intended to resolve an AttributeError: 'str' object has no attribute 'DESCRIPTOR' that occurs when packaging messages to dictionaries using protobuf.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

MengqingCao · 2025-07-25T01:34:43Z

PTAL, thx! @ruisearch42 @noemotiovon

gemini-code-assist

Code Review

This pull request updates the protobuf dependency to address a packaging issue. A suggestion has been made to use a more specific protobuf version.

gemini-code-assist · 2025-07-25T01:35:22Z

python/requirements.txt

 msgpack<2.0.0,>=1.0.0
 packaging
-protobuf!=3.19.5,>=3.15.3
+protobuf>3.20.0


Consider using a more specific protobuf version to avoid potential issues with a .0 release. It's often safer to avoid .0 releases and use >=3.20.1 since 3.20.0 was a release with significant changes and 3.20.1 contains bug fixes.

protobuf>=3.20.1

agree with the AI, let's do >=3.20.3 since it should be only bug fixes (https://pypi.org/project/protobuf/3.20.3/)

ping @MengqingCao ^

oh sorry for missing that, I'll update right now.

noemotiovon · 2025-07-25T01:38:34Z

LGTM! Appreciate your effort.

### What this PR does / why we need it? Fix protobuf version in Dockerfile to resolve `AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict` using protobuf. will remove version specification after ray-project/ray#54910 is merged ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0e36abf Signed-off-by: MengqingCao <[email protected]>

israbbani

Looks reasonable to me. @edoakes @jjyao @aslonnie merge if no objections.

edoakes

Good with me

edoakes

Sorry, scanned it too quickly. We also need to update setup.py (per the comment above: https://github.com/ray-project/ray/pull/54910/files#diff-b72f6e5561c432513e240838ae1eeb3f85237fa3ed5d701ad4c3be2a55c57b9dR5)

MengqingCao · 2025-08-06T02:14:08Z

Sorry, scanned it too quickly. We also need to update setup.py (per the comment above: https://github.com/ray-project/ray/pull/54910/files#diff-b72f6e5561c432513e240838ae1eeb3f85237fa3ed5d701ad4c3be2a55c57b9dR5)

Thanks for pointing that, updated now :-)

aslonnie · 2025-08-06T03:56:33Z

well.. if core team says it is okay, I have no objection..

this is practically firing ray users that cannot upgrade protobuf to >3.20.

I wonder if there is a min reproduce script with ray (rather than through vllm) that can prove that ray (core) does not work with protobuf 3.20 or below any more.

there is basically only protobuf 3.20.3 that is above 3.20.0. maybe it is better to just say protobuf>=4 now..

edoakes · 2025-08-06T21:03:57Z

3.20 is from 2022 and we already required >3.15.3

aslonnie

defer for @edoakes for final review actions.

aslonnie · 2025-08-06T23:11:51Z

the failing gpu tests should be already fixed on master.

MengqingCao · 2025-08-07T11:46:49Z

the failing gpu tests should be already fixed on master.

Thanks for this info, I have rebased the code to the latest master now

Signed-off-by: MengqingCao <[email protected]>

MengqingCao · 2025-08-11T02:19:11Z

It seems CI failed due to network issue, could you help retrigger this? @edoakes

Fix protobuf version in Dockerfile to resolve `AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict` using protobuf. will remove version specification after ray-project/ray#54910 is merged N/A CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0e36abf Signed-off-by: MengqingCao <[email protected]>

edoakes · 2025-08-11T15:18:51Z

It seems CI failed due to network issue, could you help retrigger this? @edoakes

Done. You can always re-trigger by merging latest master and pushing as well.

MengqingCao · 2025-08-11T22:59:27Z

Got it, thanks!

…

---- Replied Message ---- | From | Edward ***@***.***> | | Date | 08/11/2025 23:19 | | To | ***@***.***> | | Cc | Mengqing ***@***.***>***@***.***> | | Subject | Re: [ray-project/ray] [Build][Bugfix] Fix protobuf version (PR #54910) | edoakes left a comment (ray-project/ray#54910) It seems CI failed due to network issue, could you help retrigger this? @edoakes Done. You can always re-trigger by merging latest master and pushing as well. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

This pr fixes the `AttributeError: 'str' object has no attribute 'DESCRIPTOR'` when packaging message to dict using `protobuf` Closes #54849 Signed-off-by: MengqingCao <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: sampan <[email protected]>

### What this PR does / why we need it? Fix protobuf version in Dockerfile to resolve `AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict` using protobuf. will remove version specification after ray-project/ray#54910 is merged backport of #2028 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with new added test. --------- Signed-off-by: MengqingCao <[email protected]>

This pr fixes the `AttributeError: 'str' object has no attribute 'DESCRIPTOR'` when packaging message to dict using `protobuf` Closes ray-project#54849 Signed-off-by: MengqingCao <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: Andrew Grosser <[email protected]>

This pr fixes the `AttributeError: 'str' object has no attribute 'DESCRIPTOR'` when packaging message to dict using `protobuf` Closes ray-project#54849 Signed-off-by: MengqingCao <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: jugalshah291 <[email protected]>

### What this PR does / why we need it? Fix protobuf version in Dockerfile to resolve `AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict` using protobuf. will remove version specification after ray-project/ray#54910 is merged ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0e36abf Signed-off-by: MengqingCao <[email protected]>

This pr fixes the `AttributeError: 'str' object has no attribute 'DESCRIPTOR'` when packaging message to dict using `protobuf` Closes ray-project#54849 Signed-off-by: MengqingCao <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>

### What this PR does / why we need it? Fix protobuf version in Dockerfile to resolve `AttributeError: 'str' object has no attribute 'DESCRIPTOR' when packaging message to dict` using protobuf. will remove version specification after ray-project/ray#54910 is merged ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with existing test. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0e36abf Signed-off-by: MengqingCao <[email protected]>

gemini-code-assist bot reviewed Jul 25, 2025

View reviewed changes

ray-gardener bot added community-contribution Contributed by the community core Issues that should be addressed in Ray Core labels Jul 25, 2025

MengqingCao mentioned this pull request Jul 26, 2025

[Build][Ray] Fix protobuf version in Dockerfile vllm-project/vllm-ascend#2028

Merged

israbbani requested a review from a team August 5, 2025 21:52

israbbani approved these changes Aug 5, 2025

View reviewed changes

edoakes approved these changes Aug 5, 2025

View reviewed changes

edoakes requested changes Aug 5, 2025

View reviewed changes

MengqingCao requested review from aslonnie and richardliaw as code owners August 6, 2025 02:13

edoakes added the go add ONLY when ready to merge, run all tests label Aug 6, 2025

aslonnie approved these changes Aug 6, 2025

View reviewed changes

MengqingCao force-pushed the master branch from df61419 to f3de97f Compare August 7, 2025 11:40

[Build][Bugfix] Fix protobuf version

5a172b9

Signed-off-by: MengqingCao <[email protected]>

MengqingCao force-pushed the master branch from f3de97f to 5a172b9 Compare August 8, 2025 02:38

MengqingCao mentioned this pull request Aug 11, 2025

[v0.9.1][Build][Ray] Fix protobuf version in Dockerfile (#2028) vllm-project/vllm-ascend#2306

Merged

Merge branch 'master' into master

d2ff993

edoakes approved these changes Aug 11, 2025

View reviewed changes

edoakes enabled auto-merge (squash) August 11, 2025 15:19

edoakes merged commit f9373d2 into ray-project:master Aug 11, 2025
6 checks passed

[Build][Bugfix] Fix protobuf version #54910

[Build][Bugfix] Fix protobuf version #54910

Uh oh!

Conversation

MengqingCao commented Jul 25, 2025

Why are these changes needed?

Related issue number

Checks

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

MengqingCao commented Jul 25, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

edoakes Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

edoakes Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

MengqingCao Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

noemotiovon commented Jul 25, 2025

Uh oh!

israbbani left a comment

Choose a reason for hiding this comment

Uh oh!

edoakes left a comment

Choose a reason for hiding this comment

Uh oh!

edoakes left a comment

Choose a reason for hiding this comment

Uh oh!

MengqingCao commented Aug 6, 2025

Uh oh!

aslonnie commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edoakes commented Aug 6, 2025

Uh oh!

aslonnie left a comment

Choose a reason for hiding this comment

Uh oh!

aslonnie commented Aug 6, 2025

Uh oh!

MengqingCao commented Aug 7, 2025

Uh oh!

MengqingCao commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edoakes commented Aug 11, 2025

Uh oh!

Uh oh!

MengqingCao commented Aug 11, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aslonnie commented Aug 6, 2025 •

edited

Loading

MengqingCao commented Aug 11, 2025 •

edited

Loading