Skip to content

fix MAX chart not being a dotted line#53184

Merged
matthewdeng merged 1 commit intoray-project:masterfrom
alanwguo:fix-metrics-max
May 20, 2025
Merged

fix MAX chart not being a dotted line#53184
matthewdeng merged 1 commit intoray-project:masterfrom
alanwguo:fix-metrics-max

Conversation

@alanwguo
Copy link
Copy Markdown
Contributor

@alanwguo alanwguo commented May 20, 2025

Why are these changes needed?

Adding back some default panel configurations that were accidentally removed in a prior PR #52719

Before:
Screenshot 2025-05-20 at 2 31 19 PM

After:
Screenshot 2025-05-20 at 2 30 44 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo alanwguo requested a review from eicherseiji May 20, 2025 21:32
Copy link
Copy Markdown
Contributor

@eicherseiji eicherseiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Copy Markdown
Contributor

@dayshah dayshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@matthewdeng matthewdeng enabled auto-merge (squash) May 20, 2025 22:21
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 20, 2025
@matthewdeng matthewdeng merged commit bc87b73 into ray-project:master May 20, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants