-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Core] Add bundle_label_selector scheduling logic #52988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add bundle_label_selector scheduling logic #52988
Conversation
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
MengjinYan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@dayshah or @israbbani Do you mind take a brief look from c++'s perspective to see if there is any c++ particular comments? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor cpp nit, otherwise lgtm from cpp perspective. +1 on @MengjinYan comments
Co-authored-by: Dhyey Shah <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Co-authored-by: Dhyey Shah <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Why are these changes needed?
This PR adds the
bundle_label_selectoroption to Ray PlacementGroups, applying the label selectors on a per-bundle level to define label constraints for scheduling bundles on a node.This PR passes the
bundle_label_selectorfrom thePlacementGroupoptions to the Raylet where thePlacementGroupSpecis built. InsidePlacementGroupSpec, each label selector is added to its correspondingBundlemessage, and then added to theResourceRequestinComputeResourceswhen theBundleSpecis constructed. This enables the cluster resource scheduler to check for required labels when callingIsFeasibleandIsAvailableon a Node.Related issue number
#51564
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.