Update --labels and add --labels-file options for Label Selector API
#51706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
35 tasks
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
8 tasks
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
edoakes
reviewed
Apr 2, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
Looks good, minor comments
One larger comment: let's rename the argument to --labels-file (it more closely matches some other CLI options we have elsewhere, such as --config-file for serve)
ryanaoleary
changed the title
--labels and add --labels-from-file options for Label Selector API--labels and add --labels-file options for Label Selector API
Signed-off-by: Ryan O'Leary <[email protected]>
edoakes
reviewed
Apr 2, 2025
Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: ryanaoleary <[email protected]>
edoakes
reviewed
Apr 2, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
I believe you will need to add entries to the tests BUILD file for these tests to run (unless something changed recently to automatically pick them up)
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Collaborator
|
ping when CI passes (want to spot check and make sure tests ran as expected) |
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Contributor
Author
@edoakes the PR is now passing the CI, I checked and it looks like the new test file is being ran: |
jjyao
added a commit
to jjyao/ray
that referenced
this pull request
Apr 7, 2025
…elector API (ray-project#51706)" This reverts commit 0a5f970.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates the
--labelsoption toray startorray initto accept a string list of key-value pairs mapping label names to label values. Labels follow Kubernetes label syntax. This PR also adds a--labels-fileargument to support sourcing labels from a file. Files are expected to contain a valid JSON string containing a serialized key-value pair map. We useparse_node_labels_jsonto parse the argument passed to--labels-file.Related issue number
#51564
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.