Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Clarify the relation between 'uv run' and 'uv pip' support #51599

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

Fixes #51195

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz requested a review from a team as a code owner March 21, 2025 18:18
Copy link
Contributor

@crypdick crypdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pcmoritz pcmoritz enabled auto-merge (squash) March 21, 2025 18:23
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 21, 2025
@edoakes
Copy link
Collaborator

edoakes commented Mar 21, 2025

@pcmoritz should we continue to support both?

@pcmoritz
Copy link
Contributor Author

Given that uv supports both it seems natural that we do so too -- if uv run turns out to be much more popular I'd be open to remove uv pip.

Do we currently have telemetry on which runtime environment plugins are used? We can distinguish them via uv vs. py_executable :)

@pcmoritz pcmoritz merged commit ad3e5d5 into master Mar 21, 2025
6 checks passed
@pcmoritz pcmoritz deleted the uv-pip-vs-uv-run-clarification branch March 21, 2025 19:15
@edoakes
Copy link
Collaborator

edoakes commented Mar 21, 2025

Do we currently have telemetry on which runtime environment plugins are used? We can distinguish them via uv vs. py_executable :)

Not atm but it can be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] API Reference: uv
3 participants