[core] Integrate scoped dup2 #51179
Merged
[core] Integrate scoped dup2 #51179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/integrate-scoped-dup2
branch
from
4ad550d to
811ef38
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/integrate-scoped-dup2
branch
from
811ef38 to
07b7776
Compare
jjyao
approved these changes
Mar 13, 2025
aslonnie
added a commit
that referenced
this pull request
Mar 14, 2025
dentiny
added a commit
to dentiny/ray
that referenced
this pull request
Mar 14, 2025
Signed-off-by: dentiny <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
Signed-off-by: dentiny <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Signed-off-by: dentiny <[email protected]> Signed-off-by: Jay Chia <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Reverts ray-project#51179 Signed-off-by: Jay Chia <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Signed-off-by: dentiny <[email protected]> Signed-off-by: Jay Chia <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Reverts ray-project#51179 Signed-off-by: Jay Chia <[email protected]>
edoakes
pushed a commit
that referenced
this pull request
Mar 21, 2025
This PR is stacked upon #51179, to make redirection stream unit testable. Basically a no-op change, to extract redirection logic out into a separate file, and leave exit hook and global registry where they're now. --------- Signed-off-by: dentiny <[email protected]>
Drice1999
pushed a commit
to Drice1999/ray
that referenced
this pull request
Mar 23, 2025
Signed-off-by: dentiny <[email protected]>
Drice1999
pushed a commit
to Drice1999/ray
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR for #50439, which integrates dup2 wrapper into stream redirection.