[core] Block before running gpu tests #51131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <[email protected]>
aslonnie
reviewed
Mar 6, 2025
Comment on lines
+402
to
+403
| - block: "run multi gpu tests" | ||
| if: build.env("BUILDKITE_PIPELINE_ID") == "0189942e-0876-4b8f-80a4-617f988ec59b" || build.env("BUILDKITE_PIPELINE_ID") == "018f4f1e-1b73-4906-9802-92422e3badaa" |
There was a problem hiding this comment.
please give it a key and add depends_on in the multi gpu tests.
Signed-off-by: dayshah <[email protected]>
Signed-off-by: dayshah <[email protected]>
aslonnie
approved these changes
Mar 6, 2025
ruisearch42
approved these changes
Mar 6, 2025
| @@ -409,4 +416,4 @@ steps: | |||
| --build-name coregpubuild | |||
| --only-tags multi_gpu | |||
| --install-mask serve | |||
| depends_on: coregpubuild | |||
There was a problem hiding this comment.
QQ: should coregpubuild be kept?
There was a problem hiding this comment.
so i'm actually unsure if we should keep that because it's not always reliable, ex. when I change the actual tests it doesn't always actually run these tests. I think it makes more sense to just keep it fully up to the user.
There was a problem hiding this comment.
I'm good w/ making it fully manual (like win & mac tests)
There was a problem hiding this comment.
talked to lonnie -> still need depends on coregpubuild because it still depends on like the actual build
Signed-off-by: dayshah <[email protected]>
elimelt
pushed a commit
to elimelt/ray
that referenced
this pull request
Mar 9, 2025
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests. --------- Signed-off-by: dayshah <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests. --------- Signed-off-by: dayshah <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests. --------- Signed-off-by: dayshah <[email protected]> Signed-off-by: Jay Chia <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests. --------- Signed-off-by: dayshah <[email protected]> Signed-off-by: Jay Chia <[email protected]>
Drice1999
pushed a commit
to Drice1999/ray
that referenced
this pull request
Mar 23, 2025
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests. --------- Signed-off-by: dayshah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A lot of things change coregpubuild so the multi gpu tests run more often than they need to. We're moving to manually running these multi-gpu tests.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.