[llm.serving] Address dependencies related issues for llm serving#50785
Merged
aslonnie merged 2 commits intoray-project:masterfrom Feb 21, 2025
Merged
[llm.serving] Address dependencies related issues for llm serving#50785aslonnie merged 2 commits intoray-project:masterfrom
aslonnie merged 2 commits intoray-project:masterfrom
Conversation
Signed-off-by: Gene Su <e870252314@gmail.com>
GeneDer
requested review from
aslonnie,
edoakes and
richardliaw
as code owners
Member
Author
Signed-off-by: Gene Su <e870252314@gmail.com>
aslonnie
reviewed
Feb 21, 2025
| pillow | ||
| httpx>=0.27.2 | ||
| pynvml>=12.0.0 | ||
| xgrammar>=0.1.11, !=0.1.13, !=0.1.12 |
Collaborator
There was a problem hiding this comment.
(no action required)
this is fine, you can also just pin the version in the test here.
the test requirement is not exposed to user, so it is easy to update.
the non test requirement is saved in the wheel, and will become immutable after package release.
you might want to add things like !=0.1.13 in ray[llm]'s requirement, so that pip install ray[llm] has a higher chance to work for user.
aslonnie
approved these changes
Feb 21, 2025
Collaborator
|
llm tests are passing and llm images are building. I am merging this for you. |
kevin85421
pushed a commit
to kevin85421/ray
that referenced
this pull request
Feb 28, 2025
…y-project#50785) Two dependencies we are resolving that requires to pin `xgrammar` and `pynvml` to specific versions. Related vllm PR/ issues - vllm-project/vllm#13338 - vllm-project/vllm#12847 --------- Signed-off-by: Gene Su <e870252314@gmail.com> Signed-off-by: kaihsun <kaihsun@anyscale.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…y-project#50785) Two dependencies we are resolving that requires to pin `xgrammar` and `pynvml` to specific versions. Related vllm PR/ issues - vllm-project/vllm#13338 - vllm-project/vllm#12847 --------- Signed-off-by: Gene Su <e870252314@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…y-project#50785) Two dependencies we are resolving that requires to pin `xgrammar` and `pynvml` to specific versions. Related vllm PR/ issues - vllm-project/vllm#13338 - vllm-project/vllm#12847 --------- Signed-off-by: Gene Su <e870252314@gmail.com>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
…y-project#50785) Two dependencies we are resolving that requires to pin `xgrammar` and `pynvml` to specific versions. Related vllm PR/ issues - vllm-project/vllm#13338 - vllm-project/vllm#12847 --------- Signed-off-by: Gene Su <e870252314@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Two dependencies we are resolving that requires to pin
xgrammarandpynvmlto specific versions. Related vllm PR/ issuesRuntimeError: Failed to infer device typewith v0.7.2 vllm-project/vllm#12847Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.