[data/llm/docs] Initial draft of user guide for Data LLM APIs #50674
+274
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
changed the title
richardliaw
commented
Feb 18, 2025
ci/docker/llm.build.Dockerfile
Outdated
Comment on lines
22
to
25
| # FIXME(comaniac) | ||
| pip uninstall -y torch | ||
| pip install torch==2.5.1 --index-url https://download.pytorch.org/whl/cu121 | ||
|
|
richardliaw
commented
Feb 18, 2025
Comment on lines
57
to
82
| Configure vLLM for LLM inference | ||
| -------------------------------- | ||
|
|
||
| Use the `VLLMProcessorConfig` to configure the vLLM engine. | ||
|
|
||
| .. testcode:: | ||
|
|
||
| from ray.data.llm import VLLMProcessorConfig | ||
|
|
||
| processor_config = VLLMProcessorConfig( | ||
| model="meta-llama/Llama-3.1-8B-Instruct", | ||
| ... | ||
| ) |
There was a problem hiding this comment.
Question - What other tips should we add here about this
There was a problem hiding this comment.
Look at vllm docs for examples on setting good args too
gvspraveen
reviewed
Feb 18, 2025
|
|
||
| from ray.data.llm import VLLMProcessorConfig | ||
|
|
||
| processor_config = VLLMProcessorConfig( |
There was a problem hiding this comment.
this is small v - vLLMProcessorConfig
richardliaw
commented
Feb 18, 2025
| @@ -12,6 +12,9 @@ Offline batch inference is a process for generating model predictions on a fixed | |||
| :width: 650px | |||
| :align: center | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
Add an example for a custom evaluation pipeline, reading from huggingface etc
There was a problem hiding this comment.
I will add this later
richardliaw
commented
Feb 18, 2025
richardliaw
changed the title
Signed-off-by: Richard Liaw <[email protected]>
richardliaw
force-pushed
the
batchllm-docs
branch
from
c144bf9 to
5568401
Compare
gvspraveen
approved these changes
Feb 18, 2025
comaniac
approved these changes
Feb 18, 2025
Co-authored-by: Cody Yu <[email protected]> Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Co-authored-by: Cody Yu <[email protected]> Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
Signed-off-by: Richard Liaw <[email protected]>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 20, 2025
…oject#50674) ## Why are these changes needed? Adds user guide and link-ins for Ray Data documentation. This is part of the ray-project#50639 thread of work. This is based on ray-project#50494 cc @comaniac @gvspraveen @kouroshHakha ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Richard Liaw <[email protected]> Co-authored-by: Cody Yu <[email protected]> Signed-off-by: 400Ping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds user guide and link-ins for Ray Data documentation.
This is part of the #50639 thread of work.
This is based on #50494
cc @comaniac @gvspraveen @kouroshHakha
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.