Skip to content

[rllib] Give error if sample_async is used with pytorch for A3C #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericl merged 3 commits into from
Jun 26, 2019
Merged

[rllib] Give error if sample_async is used with pytorch for A3C #5000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fe64d2
give error if sample_async is used with pytorch
pcmoritz Jun 19, 2019
4f6e1e8
update
pcmoritz Jun 19, 2019
37ff8f7
Update a3c.py
ericl Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/ray/rllib/agents/a3c/a3c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ def get_policy_class(config):
def validate_config(config):
if config["entropy_coeff"] < 0:
raise DeprecationWarning("entropy_coeff must be >= 0")
if config["sample_async"] and config["use_pytorch"]:
raise ValueError(
"The sample_async option is not supported with use_pytorch: "
"Multithreading can be lead to crashes if used with pytorch.")
Copy link
Contributor

@ericl ericl Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Shall we also turn it off by default?

Copy link
Contributor Author

@pcmoritz pcmoritz Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, is it beneficial if used with TensorFlow?



def make_async_optimizer(workers, config):
Expand Down