Skip to content

[Data] Deprecate meta_provider parameter of read APIs #48690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bveeramani merged 4 commits into from
Nov 12, 2024
Merged

[Data] Deprecate meta_provider parameter of read APIs #48690

bveeramani merged 4 commits into from
Nov 12, 2024

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 11, 2024 •
edited
Loading

Why are these changes needed?

Metadata providers are specific to current implementation of read APIs. To enable us to change the implementation, this PR deprecates the meta_provider parameter and decouples metadata providers from the user-facing interface.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Deprecate meta provider
97826ff 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Update date
4e4b579 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Update docstrings
e097a1c 
Signed-off-by: Balaji Veeramani <[email protected]>
omatthew98
omatthew98 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@bveeramani bveeramani enabled auto-merge (squash) November 12, 2024 18:33
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 12, 2024
@github-actions github-actions bot disabled auto-merge November 12, 2024 19:44
@bveeramani bveeramani merged commit d222ce1 into master Nov 12, 2024
@bveeramani bveeramani deleted the deprecate-meta-provider branch November 12, 2024 21:27
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Deprecate meta_provider parameter of read APIs (ray-project#…
3a0a7c3 
…48690)

Metadata providers are specific to current implementation of read APIs.
To enable us to change the implementation, this PR deprecates the
`meta_provider` parameter and decouples metadata providers from the
user-facing interface.
---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omatthew98 omatthew98 omatthew98 approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin

@srinathk10 srinathk10 Awaiting requested review from srinathk10

Assignees

@omatthew98 omatthew98

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bveeramani @omatthew98 @hainesmichaelc