Skip to content

[Data] Relax timeout on TFRecords benchmark #48688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bveeramani merged 3 commits into from
Nov 12, 2024
Merged

[Data] Relax timeout on TFRecords benchmark #48688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5284f33
Initial commit
bveeramani Nov 11, 2024
54b9abc
Remove comment
bveeramani Nov 11, 2024
39d4ada
Update comment
bveeramani Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions release/nightly_tests/dataset/read_tfrecords_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,10 @@ def generate_features(batch):
features = {k: v for (k, v) in features.items() if len(v) > 0}
return pa.table(features)

ds = ray.data.range(num_rows).map_batches(generate_features)
assert ds.count() == num_rows, ds.count()
Copy link
Member Author

@bveeramani bveeramani Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this assertion to avoid executing the pipeline twice


tfrecords_dir = tempfile.mkdtemp()
ds.write_tfrecords(tfrecords_dir)
ray.data.range(num_rows).map_batches(generate_features).write_tfrecords(
tfrecords_dir
)
return tfrecords_dir


Expand Down
4 changes: 2 additions & 2 deletions release/release_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4342,8 +4342,8 @@
cluster_compute: single_node_benchmark_compute.yaml

run:
# Expect the benchmark to finish around 22 minutes.
timeout: 1800
# Expect the benchmark to finish around 30 minutes.
timeout: 2700
script: python read_tfrecords_benchmark.py

variations:
Expand Down