[RLlib] Cleanup examples folder vol 32: Enable RLlib + Serve example in CI and translate to new API stack. #48687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
sven1977
added
serve
simonsays1980
approved these changes
Nov 11, 2024
Contributor
simonsays1980
left a comment
simonsays1980
left a comment
There was a problem hiding this comment.
LGTM. For the future we should extend this example by a connector run as this will probably be the default in practice.
| action = self.algo.compute_single_action(obs) | ||
| # Compute and return the action for the given observation (create a batch | ||
| # with B=1 and convert to torch). | ||
| output = self.rl_module.forward_inference( |
Contributor
There was a problem hiding this comment.
For a better practical usability we might need to enlarge this example by a connector run. This might be the default we will see in practice.
Contributor
Author
There was a problem hiding this comment.
Yeah, makes sense!
Maybe add another example where we restore the EnvToModule pipeline + the RLModule.
Like we do in the ray.rllib.examples.inference.policy_inference_after_training_w_connector.py script.
|
|
||
| # If episode done -> reset to get initial observation of new episode. | ||
| if done: | ||
| if terminated or truncated: |
Signed-off-by: sven1977 <[email protected]>
…le_rllib_plus_serve_example_in_ci
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…in CI and translate to new API stack. (ray-project#48687) Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…in CI and translate to new API stack. (ray-project#48687) Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder vol 32: Enable RLlib + Serve example in CI and translate to new API stack.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.