Skip to content

[tune] Fix CLI test #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertnishihara merged 1 commit into from
May 16, 2019
Merged

[tune] Fix CLI test #4801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/tune/tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __exit__(self, *args):

@pytest.fixture
def start_ray():
ray.init()
ray.init(log_to_driver=False)
Copy link
Collaborator

@robertnishihara robertnishihara May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to make this change only for test_ls since that test captures stdout/stderr. Having the stdout/stderr could make tests easier to debug and also will more accurately simulate real usage.

Copy link
Contributor Author

@richardliaw richardliaw May 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is actually mainly for testing the stdout of the CLI (2 of the 3 tests capture output, and commands.py is a file for CLI method calls), so I figured it'd make much more sense turning off output logging. The CLI doesn't invoke Ray/interact with Ray workers.

_register_all()
yield
ray.shutdown()
Expand Down