Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split python/ray/tests/test_actor_retry over two files #47188

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Split python/ray/tests/test_actor_retry over two files #47188

merged 4 commits into from
Aug 29, 2024

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Aug 18, 2024 •
edited
Loading

Why are these changes needed?

The test_actor_retry tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Related issue number

Toward solving #43845.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mattip mattip requested a review from a team as a code owner August 18, 2024 08:59
@mattip
Copy link
Contributor Author

mattip commented Aug 18, 2024

cc @anyscalesam

@aslonnie aslonnie requested a review from jjyao August 18, 2024 23:41
aslonnie
aslonnie reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any logic that this splitting is following? like which test goes to 1 and which goes to 2? why is the move interleaving?

@mattip
Copy link
Contributor Author

mattip commented Aug 19, 2024

There are two overall strategies: TroubleMaker and AsyncTroubleMaker. I moved the (simpler) TroubleMaker-only tests to the new file, and left the ones that use the AsyncTroubleMaker

@mattip
Copy link
Contributor Author

mattip commented Aug 27, 2024

@anyscalesam @aslonnie any more questions?

@aslonnie aslonnie requested a review from rynewang August 27, 2024 07:27
@aslonnie
Copy link
Collaborator

asking @rynewang @jjyao for opinions.

@rynewang
Copy link
Contributor

I'm ok with this.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Aug 28, 2024
@anyscalesam anyscalesam enabled auto-merge (squash) August 28, 2024 21:53
@anyscalesam anyscalesam added windows core Issues that should be addressed in Ray Core labels Aug 28, 2024
@mattip
Copy link
Contributor Author

mattip commented Aug 29, 2024

Auto-merge did not trigger. Do I need to rebase the PR?

@aslonnie aslonnie disabled auto-merge August 29, 2024 14:20
@aslonnie aslonnie merged commit f0f29bd into ray-project:master Aug 29, 2024
6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
@mattip @ujjawal-khare
Split python/ray/tests/test_actor_retry over two files (ray-project#4…
3557f98 
…7188)

The `test_actor_retry` tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Toward solving ray-project#43845.

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@mattip @ujjawal-khare
Split python/ray/tests/test_actor_retry over two files (ray-project#4…
5376479 
…7188)

The `test_actor_retry` tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Toward solving ray-project#43845.

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@mattip @ujjawal-khare
Split python/ray/tests/test_actor_retry over two files (ray-project#4…
90cc33d 
…7188)

The `test_actor_retry` tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Toward solving ray-project#43845.

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@mattip @ujjawal-khare
Split python/ray/tests/test_actor_retry over two files (ray-project#4…
063d004 
…7188)

The `test_actor_retry` tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Toward solving ray-project#43845.

Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@mattip @ujjawal-khare
Split python/ray/tests/test_actor_retry over two files (ray-project#4…
9f76655 
…7188)

The `test_actor_retry` tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Toward solving ray-project#43845.

Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynewang rynewang rynewang approved these changes

@aslonnie aslonnie aslonnie approved these changes

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@rynewang rynewang

Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattip @aslonnie @rynewang @anyscalesam