Skip to content

Conversation

@omatthew98
Copy link
Contributor

Why are these changes needed?

Do not merge. Equivalent changes to #46669 but based off of master to run against the full suite of tests.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label Jul 16, 2024
@omatthew98
Copy link
Contributor Author

Closing, was just testing changes on master. Changes have been merged into ray-py312 branch.

@omatthew98 omatthew98 closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant