Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tempfile issues #4605

Merged
merged 9 commits into from
May 5, 2019
Merged

Fix tempfile issues #4605

merged 9 commits into from
May 5, 2019

Conversation

suquark
Copy link
Member

@suquark suquark commented Apr 11, 2019 •
edited
Loading

What do these changes do?

This PR addresses some crucial tempfile issues.

Related issue number

Closes #4330 #4593 #4594

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

TODO list:

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/432/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/433/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/434/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13734/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13735/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13736/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/447/
Test PASSed.

@suquark suquark mentioned this pull request Apr 12, 2019
Closed
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13753/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/470/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13784/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/471/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13785/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/626/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14006/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/662/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14064/
Test FAILed.

@suquark suquark changed the title WIP: Fix tempfile issues Fix tempfile issues May 2, 2019
@suquark
Copy link
Member Author

suquark commented May 2, 2019

Ready for review

@robertnishihara robertnishihara mentioned this pull request May 4, 2019
Closed
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/695/
Test PASSed.

robertnishihara
robertnishihara reviewed May 4, 2019
View reviewed changes
python/ray/tests/test_tempfile.py Outdated

def test_session_dir_uniqueness():
session_dirs = set()
for _ in range(50):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 is too large. That could add around 50 seconds to the test. How about 2 or 3?

robertnishihara
robertnishihara reviewed May 4, 2019
View reviewed changes
Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suquark nice work, I tried it out and this seems to work great.

Do we have a test to make sure that the --temp-dir flag to ray start does the right thing? And in particular, that when that is used, /tmp/ray is not created?

@robertnishihara robertnishihara mentioned this pull request May 4, 2019
Closed
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14100/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/700/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14109/
Test FAILed.

robertnishihara
robertnishihara approved these changes May 5, 2019
View reviewed changes
Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@robertnishihara robertnishihara merged commit bd00735 into ray-project:master May 5, 2019
@robertnishihara robertnishihara mentioned this pull request May 5, 2019
Closed
@mitar
Copy link
Member

mitar commented May 5, 2019

Has this addressed #4641?

@robertnishihara robertnishihara mentioned this pull request May 5, 2019
Open
@robertnishihara
Copy link
Collaborator

I think so, thanks!

pengzhenghao pushed a commit to pengzhenghao/ray that referenced this pull request May 6, 2019
@suquark
Fix tempfile issues (ray-project#4605)
b1509f3
@guoyuhong
Copy link
Contributor

@suquark It looks like this PR introduces some CI failures to master and I can also observe this test failure in my other PRs. Could you take a look? https://travis-ci.com/ray-project/ray/jobs/198094058
image

@suquark
Copy link
Member Author

suquark commented May 8, 2019

@guoyuhong It's a bit strange that the temp dir wasn't deleted. Let me investigate it.

@suquark suquark mentioned this pull request May 8, 2019
Closed
1 task
@jovany-wang jovany-wang mentioned this pull request Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

@guoyuhong guoyuhong Awaiting requested review from guoyuhong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No session_* subfolder if temp_dir is specified
5 participants
@suquark @AmplabJenkins @mitar @robertnishihara @guoyuhong