Skip to content

Conversation

@SieversLeon
Copy link
Contributor

Implemented clipping for actions in compute_single_action, follow-up to #4413.

@SieversLeon
Copy link
Contributor Author

Also, what is the general reason behind clipping not being directly embedded in the graph?

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13193/
Test FAILed.

Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, thanks!

@ericl
Copy link
Contributor

ericl commented Mar 22, 2019

Looks like the linter is failing: https://travis-ci.com/ray-project/ray/jobs/186998035

you can run scripts/format.sh to fix

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13199/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13302/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13303/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13323/
Test FAILed.

@ericl
Copy link
Contributor

ericl commented Mar 29, 2019

Test failure looks unrelated.

@ericl ericl merged commit f4b313e into ray-project:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants