-
Notifications
You must be signed in to change notification settings - Fork 7k
[rllib] Moved clip_action into policy_graph; Clip actions in compute_single_action #4459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also, what is the general reason behind clipping not being directly embedded in the graph? |
|
Can one of the admins verify this patch? |
|
Test FAILed. |
ericl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, thanks!
|
Looks like the linter is failing: https://travis-ci.com/ray-project/ray/jobs/186998035 you can run scripts/format.sh to fix |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test failure looks unrelated. |
Implemented clipping for actions in compute_single_action, follow-up to #4413.