Skip to content

Conversation

@andrewztan
Copy link
Contributor

What do these changes do?

Adds output flag (-o / --output) to ls / lsx commands for Tune CLI. Builds on top of #3983

@andrewztan
Copy link
Contributor Author

@richardliaw

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12736/
Test FAILed.

@hartikainen
Copy link
Contributor

Would it be better to output these in a csv instead of pkl? Considering that the data being outputted does not need to have python objects saved, i.e. the data is tabular, I think it would be better serialize the things with something else than pickle.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12748/
Test PASSed.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12798/
Test PASSed.

@andrewztan
Copy link
Contributor Author

@richardliaw @hartikainen ready for review / merge

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12804/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12811/
Test FAILed.

@hartikainen
Copy link
Contributor

Looks good!

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12812/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12817/
Test FAILed.

@richardliaw richardliaw merged commit 87bfa1c into ray-project:master Mar 13, 2019
@andrewztan andrewztan deleted the ls_output branch March 13, 2019 08:55
@richardliaw
Copy link
Contributor

We should add this to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants