Skip to content

[tune] Fix worker recovery by setting force=False when calling logger sync_now #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardliaw merged 1 commit into from
Mar 8, 2019
Merged

[tune] Fix worker recovery by setting force=False when calling logger sync_now #4302

richardliaw merged 1 commit into from
Mar 8, 2019

Conversation

@hartikainen
Copy link
Contributor

@hartikainen hartikainen commented Mar 8, 2019 •
edited
Loading

What do these changes do?

Fixes a tune autoscaling problem where worker recovery causes things to stall.

@hartikainen hartikainen requested a review from richardliaw March 8, 2019 00:50
@hartikainen hartikainen changed the title Try setting force=False when calling logger sync_now [tune] Fix worker recovery by setting force=False when calling logger sync_now Mar 8, 2019
@richardliaw richardliaw self-assigned this Mar 8, 2019
richardliaw
richardliaw approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Eric's #4218 goes in, we should also add warn_if_slow to most of these things.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 8, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12679/
Test FAILed.

@hartikainen hartikainen force-pushed the fix/tune-logger-flush-force branch from 6ecba9b to 8448c36 Compare March 8, 2019 03:56
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 8, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12685/
Test FAILed.

@richardliaw richardliaw merged commit 7e4b482 into ray-project:master Mar 8, 2019
@hartikainen hartikainen deleted the fix/tune-logger-flush-force branch March 8, 2019 19:01
@richardliaw richardliaw mentioned this pull request Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hartikainen @AmplabJenkins @richardliaw