Skip to content

Remove Jenkins backend tests and add new long running stress test. #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcmoritz merged 6 commits into from
Mar 8, 2019
Merged

Remove Jenkins backend tests and add new long running stress test. #4288

pcmoritz merged 6 commits into from
Mar 8, 2019

Conversation

@robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Mar 7, 2019 •
edited
Loading

This fixes #4283. It also removes almost all of the Jenkins backend tests. test_0.py doesn't really do anything interesting and is flaky. remove_driver_test.py should be covered by test_multi_node.py, and many_driver_test.py should be covered by the new stress test I added, which essentially creates drivers in an infinite loop.

I also removed the multi_node_docker_test.py file because that has been replaced by cluster_utils.py.

robertnishihara
robertnishihara commented Mar 7, 2019
View reviewed changes
ci/jenkins_tests/run_multi_node_tests.sh Outdated
DOCKER_SHA=$($ROOT_DIR/../../build-docker.sh --output-sha --no-cache)
echo "Using Docker image" $DOCKER_SHA

######################## RAY BACKEND TESTS #################################
Copy link
Collaborator Author

@robertnishihara robertnishihara Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to the front so I can see the Jenkins results more quickly, but will move back to the end before merging.

Copy link
Collaborator Author

@robertnishihara robertnishihara Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, it doesn't take very long I think, so maybe it's fine here.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 7, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12635/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 7, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12642/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 8, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12672/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 8, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12690/
Test PASSed.

@pcmoritz pcmoritz merged commit fd2d8c2 into ray-project:master Mar 8, 2019
@robertnishihara robertnishihara deleted the jenkinstest branch March 8, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jenkins test_0.py failing frequently.

3 participants

@robertnishihara @AmplabJenkins @pcmoritz