Ujjawal/fix/ds unique #42776
Closed
Ujjawal/fix/ds unique #42776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ujjawal <[email protected]>
Signed-off-by: Ujjawal <[email protected]>
Signed-off-by: Ujjawal <[email protected]>
Signed-off-by: Ujjawal <[email protected]>
ujjawal-khare-27
requested review from
Zandew,
amogkam,
bveeramani,
c21,
ericl,
raulchen,
scottjlee,
scv119 and
stephanie-wang
as code owners
Signed-off-by: Ujjawal <[email protected]>
Signed-off-by: Ujjawal <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
stale
bot
removed
the
stale
Contributor
|
hey @ujjawal-khare-27 - thanks for submitting the PR (and apologies on leaving it dangling) - we'll make sure to see if we can get someone to review this at our next sprint planning in a week or two. |
anyscalesam
added
the
triage
8 tasks
richardliaw
added a commit
that referenced
this pull request
Nov 14, 2024
…48697) ## Why are these changes needed? This makes SortAggregate more consistent by unifying the API on the SortKey object, similar to how SortTaskSpec is implemented. ## Related issue number This is related to #42776 and #42142 Signed-off-by: Richard Liaw <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…ay-project#48697) ## Why are these changes needed? This makes SortAggregate more consistent by unifying the API on the SortKey object, similar to how SortTaskSpec is implemented. ## Related issue number This is related to ray-project#42776 and ray-project#42142 Signed-off-by: Richard Liaw <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…ay-project#48697) ## Why are these changes needed? This makes SortAggregate more consistent by unifying the API on the SortKey object, similar to how SortTaskSpec is implemented. ## Related issue number This is related to ray-project#42776 and ray-project#42142 Signed-off-by: Richard Liaw <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To be able to dataset.uniuqe on datasets with none value.
Related issue number
Closes #42142
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.