Skip to content

[rllib] Add end-to-end tests for RNN sequencing #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericl merged 3 commits into from
Mar 6, 2019
Merged

[rllib] Add end-to-end tests for RNN sequencing #4258

ericl merged 3 commits into from
Mar 6, 2019

Conversation

@ericl
Copy link
Contributor

@ericl ericl commented Mar 5, 2019

What do these changes do?

Adds two end-to-end test cases: simple optimizer, and minibatch optimizer (PPO).

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12544/
Test FAILed.

hartikainen
hartikainen approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@hartikainen hartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericl ericl merged commit 0e77a8f into ray-project:master Mar 6, 2019
adizim pushed a commit to adizim/ray that referenced this pull request Mar 12, 2019
Revert "[rllib] Add end-to-end tests for RNN sequencing (ray-project#…
f1331f1 
…4258)"

This reverts commit 0e77a8f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hartikainen hartikainen hartikainen approved these changes

Assignees

@hartikainen hartikainen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericl @AmplabJenkins @hartikainen