-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] Add policy
config to AutoscalingConfig
#42072
[Serve] Add policy
config to AutoscalingConfig
#42072
Conversation
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
@edoakes would be nice if you can give this a look as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some comments.
Mostly concerned about this base64 encoding and dynamic behavior of the policy field. If something nonstandard like this is required in a PR I expect it to be called out in the description to let reviewers know why it's necessary and what alternatives there are, if any. |
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
@edoakes @shrekris-anyscale I have addressed all the comments and removed the need to serialize policy with base64 (thanks to the idea on separating them into 2 fields). PTAL again when you have a sec! |
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Move BasicAutoscalingPolicy to a public file and add the new policy config to AutoscalingConfig. --------- Signed-off-by: Gene Su <[email protected]>
Move BasicAutoscalingPolicy to a public file and add the new policy config to AutoscalingConfig. --------- Signed-off-by: Gene Su <[email protected]>
Why are these changes needed?
Move
BasicAutoscalingPolicy
to a public file and add the newpolicy
config toAutoscalingConfig
.Related issue number
First PR for #41135
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.