-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add teardown_module to test_queue.py #4012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teardown_module to test_queue.py #4012
Conversation
|
Test FAILed. |
python/ray/test/test_queue.py
Outdated
| ray.shutdown() | ||
|
|
||
|
|
||
| def teardown_module(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be unnecessary if we are passing ray_start in everywhere, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry I thought I took out ray_start since it did not work for test_async for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it actually not work with test_async? Any idea why that is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure, it just hangs on when we try to get the results result = set(ray.get(consumers)) from the Queue https://github.com/ray-project/ray/pull/4012/files#diff-a97079c8e5770f39616578c37673e242R56
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
I suspect the issue had to do with defining the remote functions outside of the tests. I pushed some small changes. |
|
Test PASSed. |
What do these changes do?
Adds a
teardown_moduletotest_queue.pyin order to ensure that aftertest_queue.pyfinishes running, that there is no ray process still running.Related issue number