Skip to content

Conversation

@williamma12
Copy link
Contributor

What do these changes do?

Adds a teardown_module to test_queue.py in order to ensure that after test_queue.py finishes running, that there is no ray process still running.

Related issue number

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11761/
Test FAILed.

ray.shutdown()


def teardown_module():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unnecessary if we are passing ray_start in everywhere, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry I thought I took out ray_start since it did not work for test_async for some reason

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually not work with test_async? Any idea why that is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure, it just hangs on when we try to get the results result = set(ray.get(consumers)) from the Queue https://github.com/ray-project/ray/pull/4012/files#diff-a97079c8e5770f39616578c37673e242R56

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11795/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11803/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11821/
Test PASSed.

@robertnishihara
Copy link
Collaborator

I suspect the issue had to do with defining the remote functions outside of the tests. I pushed some small changes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11845/
Test PASSed.

@robertnishihara robertnishihara merged commit e1a479b into ray-project:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants