Skip to content

Conversation

@robertnishihara
Copy link
Collaborator

See #3979.

@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 7, 2019

If we want a quick fix for this, reverting the inline object pr until the valgrind issue is fixed seems the better solution to me.

Event better let's try to fix the valgrind issue.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11656/
Test PASSed.

@guoyuhong
Copy link
Contributor

As described in #4007:

object_manager_test.cc failed since 3756 when VALGRIND is used. However, this test works fine in none-valgrind case. I increased the data size above the inline object threshold and the test passed. Maybe the owner needs to take a look at why the valgrind test fails when inline object is enabled.

@robertnishihara robertnishihara deleted the failingtest branch February 14, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants