Skip to content

Only mark tasks as forwarded if they are in the lineage cache #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanie-wang merged 1 commit into from
Feb 6, 2019
Merged

Only mark tasks as forwarded if they are in the lineage cache #3958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ray/raylet/node_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,10 +1948,11 @@ void NodeManager::ForwardTask(const Task &task, const ClientID &node_id,
if (!lineage_cache_.RemoveWaitingTask(task_id)) {
RAY_LOG(WARNING) << "Task " << task_id << " already removed from the lineage"
<< " cache. This is most likely due to reconstruction.";
} else {
// Mark as forwarded so that the task and its lineage is not
// re-forwarded in the future to the receiving node.
lineage_cache_.MarkTaskAsForwarded(task_id, node_id);
}
// Mark as forwarded so that the task and its lineage is not re-forwarded
// in the future to the receiving node.
lineage_cache_.MarkTaskAsForwarded(task_id, node_id);

// Notify the task dependency manager that we are no longer responsible
// for executing this task.
Expand Down