Skip to content

[tune] Improve mnist_pytorch.py example #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardliaw merged 6 commits into from
Feb 5, 2019
Merged

[tune] Improve mnist_pytorch.py example #3894

richardliaw merged 6 commits into from
Feb 5, 2019

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Jan 30, 2019

What do these changes do?

  • Improved --no-cuda handling
  • Removed deprecated Variable usage

Related issue number

Fixes #3873

@vfdev-5
Fixes ray-project#3873
d6a40f9 
* Improved --no-cuda handling
* Removed deprecated Variable usage
@AmplabJenkins
Copy link

AmplabJenkins commented Jan 30, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11278/
Test FAILed.

@richardliaw richardliaw changed the title Fixes #3873 [tune] Improve mnist_pytorch.py example Jan 30, 2019
@richardliaw
Copy link
Contributor

richardliaw commented Jan 30, 2019

jenkins retest this please

@richardliaw
Copy link
Contributor

richardliaw commented Jan 30, 2019

This test is failing - can you resolve this? https://travis-ci.com/ray-project/ray/jobs/173926439

@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Jan 30, 2019

@richardliaw sorry for that. Yes, I can fix flake8. Thanks for pointing out

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 30, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11300/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 30, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11298/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 30, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11314/
Test FAILed.

@richardliaw
Copy link
Contributor

richardliaw commented Jan 30, 2019

jenkins retest this please

@richardliaw richardliaw self-assigned this Jan 30, 2019
@AmplabJenkins
Copy link

AmplabJenkins commented Jan 31, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11325/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 1, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11371/
Test FAILed.

@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Feb 1, 2019

@richardliaw there are some other errors in travis and the one is related to the change. Could you please explain me what does .travis/format.sh?

@richardliaw
Copy link
Contributor

richardliaw commented Feb 1, 2019

Yeah I would just run (in ray/), ./scripts/format.sh - this will automatically fix formatting for your code (we have a format standard)

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 1, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11401/
Test FAILed.

@richardliaw
Copy link
Contributor

richardliaw commented Feb 3, 2019

jenkins retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 3, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11472/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 4, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11492/
Test PASSed.

@richardliaw richardliaw merged commit b2b8417 into ray-project:master Feb 5, 2019
@vfdev-5 vfdev-5 deleted the issue_3873 branch February 5, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tune] Option --no-cuda is misleading in mnist_pytorch.py example

3 participants

@vfdev-5 @AmplabJenkins @richardliaw