Skip to content

Suppress warning for serializing different unique ID types in Python. #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephanie-wang merged 2 commits into from
Feb 5, 2019
Merged

Suppress warning for serializing different unique ID types in Python. #3872

stephanie-wang merged 2 commits into from
Feb 5, 2019

Conversation

@robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Jan 26, 2019 •
edited
Loading

This fixes #3850.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 27, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11197/
Test PASSed.

raulchen
raulchen reviewed Jan 28, 2019
View reviewed changes
python/ray/worker.py Outdated
Copy link
Contributor

@raulchen raulchen Jan 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this list duplicated in many places. Should we make it a constant? Otherwise, when someone add a new ID type, it's likely that they will forget to modify this.

Copy link
Collaborator Author

@robertnishihara robertnishihara Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@suquark
Copy link
Member

suquark commented Feb 5, 2019

Thanks for fixing that! LGTM.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 5, 2019

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11559/
Test FAILed.

@robertnishihara
Copy link
Collaborator Author

robertnishihara commented Feb 5, 2019

Jenkins, retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11561/
Test FAILed.

@stephanie-wang stephanie-wang merged commit fa4eb83 into ray-project:master Feb 5, 2019
@robertnishihara robertnishihara deleted the serializationfixes branch February 5, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulchen raulchen raulchen left review comments

@suquark suquark suquark approved these changes

@guoyuhong guoyuhong Awaiting requested review from guoyuhong

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Too many warning messages when actor handles are passed into tasks.

5 participants

@robertnishihara @AmplabJenkins @suquark @raulchen @stephanie-wang