[RLlib] Remove old gym monitor code and add new API #37922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: Rohan Potdar <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
8 tasks
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha,
krfricke and
a team
as code owners
| custom_metrics=episode.custom_metrics, | ||
| hist_data=episode.hist_data, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This is not the original concern of the PR, but I believe that we should clear our sampler of such logic that distinguishes between environments. We are not transparent about this and user has to deepdive rllib to understand/modify what is going on here.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We used to use the gym monitor API for rllib recordings.
This has not been working for a while.
This PR now replaces the legacy code with the new Gymnasium Recording API.
Prerequisite: https://github.com/ray-project/ray/pull/35698/files