Skip to content

[java] when put an object in plasma store, ignore "object alreay exists" exception #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guoyuhong merged 5 commits into from
Feb 9, 2019
Merged

[java] when put an object in plasma store, ignore "object alreay exists" exception #3687

guoyuhong merged 5 commits into from
Feb 9, 2019

Conversation

@bibabolynn
Copy link
Contributor

@bibabolynn bibabolynn commented Jan 4, 2019

@raulchen please help review , DuplicateObjectExcepton is defined in arrow project,
apache/arrow#3306

What do these changes do?

when put an object in plasma store ,plasma client stops catch exceptions, raylet needs to deal with them itself, if raylet catch "object with this ID already exists in the plasma store" exception ,a simply log would be fine

Related issue number

@raulchen raulchen changed the title [java] when put an object in plasma store, ignore "object alreay exists" exception [wip] [java] when put an object in plasma store, ignore "object alreay exists" exception Jan 4, 2019
@raulchen raulchen changed the title [wip] [java] when put an object in plasma store, ignore "object alreay exists" exception [WIP] [java] when put an object in plasma store, ignore "object alreay exists" exception Jan 4, 2019
raulchen
raulchen previously requested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unapprove this PR for now, because it depends on arrow update.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 4, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10581/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 4, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10582/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 4, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10583/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 4, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10586/
Test FAILed.

@bibabolynn bibabolynn changed the title [WIP] [java] when put an object in plasma store, ignore "object alreay exists" exception [java] when put an object in plasma store, ignore "object alreay exists" exception Jan 4, 2019
@guoyuhong guoyuhong mentioned this pull request Feb 2, 2019
Merged
guoyuhong pushed a commit to pcmoritz/ray-1 that referenced this pull request Feb 2, 2019
Fix java test by copy part code of ray-project#3687
05580d7
@raulchen
Copy link
Contributor

raulchen commented Feb 2, 2019

#3871 already includes these changes.

@raulchen raulchen closed this Feb 2, 2019
@guoyuhong
Copy link
Contributor

guoyuhong commented Feb 2, 2019

@raulchen The test is not included in that PR. The test could be added in this PR...

@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 2, 2019

yeah, we can do that!

@raulchen
Copy link
Contributor

raulchen commented Feb 2, 2019

thanks. Reopening this PR.

@raulchen raulchen reopened this Feb 2, 2019
@AmplabJenkins
Copy link

AmplabJenkins commented Feb 2, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11447/
Test PASSed.

@guoyuhong guoyuhong force-pushed the dev_plasma_exception branch from e185eb3 to 7ef0bcc Compare February 8, 2019 05:17
guoyuhong
guoyuhong approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bibabolynn for this PR. To avoid deadlock dependency of #3871 which is used to update Arrow. I have moved the change in ObjectStoreProxy.java to #3871 . Now that Arrow have been updated, this PR is unblocked. I have rebased this PR and will merge it once all tests pass.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 8, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11677/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 9, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11714/
Test PASSed.

@guoyuhong guoyuhong dismissed raulchen’s stale review February 9, 2019 10:01

The PR is rebased.

@guoyuhong
Copy link
Contributor

guoyuhong commented Feb 9, 2019

This PR is not related to python, so the test failures are not caused by this PR.

@guoyuhong guoyuhong merged commit 728031a into ray-project:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guoyuhong guoyuhong guoyuhong approved these changes

@raulchen raulchen raulchen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bibabolynn @AmplabJenkins @raulchen @guoyuhong @pcmoritz