Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib-contrib] SlateQ #36710

Merged
merged 7 commits into from
Oct 4, 2023
Merged

[RLlib-contrib] SlateQ #36710

merged 7 commits into from
Oct 4, 2023

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Jun 22, 2023

Signed-off-by: Avnish [email protected]

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@stale
Copy link

stale bot commented Aug 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 10, 2023
@sven1977 sven1977 self-assigned this Oct 2, 2023
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 2, 2023
@sven1977 sven1977 added rllib RLlib related issues rllib-contrib ray 2.8 rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Oct 3, 2023
sven1977
sven1977 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sven1977 sven1977 merged commit 910dd06 into ray-project:master Oct 4, 2023
9 of 13 checks passed
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
@avnishn
[RLlib-contrib] SlateQ. (ray-project#36710)
9ee98ae
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@avnishn
[RLlib-contrib] SlateQ. (ray-project#36710)
452ae4a 
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees

@sven1977 sven1977

Labels
ray 2.8 rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnishn @sven1977